Note: pulling in latest driverkit breaks build because of the usage of:

Error: ../../../go/pkg/mod/github.com/falcosecurity/[email protected]/cmd/local.go:90:13: undefined: unix.Utsname
Error: ../../../go/pkg/mod/github.com/falcosecurity/[email protected]/cmd/local.go:91:18: undefined: unix.Uname

in it for non-linux builds.
I am not sure whether to drop the dep in driverkit (enforcing user to pass kernelrelease/kernelversion even for local builds (it might make sense, after all the 2 parameteres are already mandatory for all others command) or to try something else (don't know what though!)

I am not sure whether to drop the dep in driverkit (enforcing user to pass kernelrelease/kernelversion even for local builds

Chose to follow this way: falcosecurity/driverkit#307

EDIT: bumped driverkit to that PR.

/reopen
Ops :D

@FedeDP: Reopened this PR.

/milestone v0.8.0

Rebased on top of master; moreover:

• it uses driverkit from fix(pkg/driverbuilder): fixed local cmd build up using os.Environ(). driverkit#319
• ran go get -u to bump all deps

Only question remaining: driverkit uses log/slog package for structured logging (avail since golang 1.21) and internally logs multiple things.
This breaks our spinner behavior. Should we:

• either disable driverkit logging (eg: by calling:

h := slog.NewTextHandler(io.Discard, &slog.HandlerOptions{})
slog.SetDefault(slog.New(h))

ie: by setting an io discarder slog as default slog instance that gets inherited by driverkit.

• or by passing our printer.Logger.Writer and printer.Logger.Level to the slog instance, like:

h := slog.NewTextHandler(printer.Logger.Writer, &slog.HandlerOptions{
		Level: printer.Logger.Level,
		ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
			if a.Key == slog.TimeKey {
				return slog.Attr{}
			}
			return a
		}})
slog.SetDefault(slog.New(h))

this way, the slog used by driverkit will print on our provided writer (without datetime attribute because we don't want that).

Another TODO:

• when build fails, we need some way to get the error, like accessing /var/lib/dkms... log. This is what we currently do in falcoctl main.

I will bump this once:

• new: driver selection logic #484
• new(pkg/driver): try to fetch kernel headers leveraging driverkit library when building drivers #476

are merged; also i need to make a new release for driverkit once falcosecurity/driverkit#324 is merged.

Bumped to driverkit v0.19.0.
There is a build issue since pkg/driver/distro imports driverkit/cmd that imports pkg/options : https://github.com/falcosecurity/driverkit/blob/master/cmd/config_options.go#L20 and that is an import cycle.
Gonna work on this asap.

#550 is the first step to fix the build; we will then need to port the changes to falcosecurity/driverkit#342 and tag driverkit v0.19.1. We should be finally fine then.

Ok driverkit v0.19.1 was tagged; the CI should now be green here, and we can proceed.
@alacuku @leogr it would be great if we could merge this before Monday since otherwise i will have to fix all go.{mod,sum} conflicts 😟

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here